Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add RouterDump and DirectTransportDump types #1195

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Node: Add RouterDump and DirectTransportDump types #1195

merged 6 commits into from
Oct 26, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Oct 26, 2023

NOTE: I'll be checking which more API types are missing and create the corresponding PRs.

@jmillan jmillan requested a review from ibc October 26, 2023 11:12
ibc
ibc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic things requested. BTW hell, I was about to do this today but ok.

node/src/Router.ts Outdated Show resolved Hide resolved
node/src/utils.ts Outdated Show resolved Hide resolved
node/src/utils.ts Outdated Show resolved Hide resolved
node/src/utils.ts Outdated Show resolved Hide resolved
@jmillan jmillan marked this pull request as draft October 26, 2023 13:26
@jmillan
Copy link
Member Author

jmillan commented Oct 26, 2023

Converting to draft as I'm going to handle the rest of the cases here.

ibc
ibc reviewed Oct 26, 2023
View reviewed changes
node/.eslintrc.js
@@ -183,6 +183,7 @@ const eslintConfig =
}
],
'space-in-parens' : [ 2, 'never' ],
'space-infix-ops' : [ 2, { 'int32Hint': false } ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I'm adding it in other projects.

ibc
ibc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a PR draft yet? IMHO this is ready.

@ibc
Copy link
Member

ibc commented Oct 26, 2023

Why a PR draft yet? IMHO this is ready.

Ah no, a test is failing... but this cannot be related to this PR...

https://github.com/versatica/mediasoup/actions/runs/6654790668/job/18083561359?pr=1195

@ibc
Copy link
Member

ibc commented Oct 26, 2023

Converting to draft as I'm going to handle the rest of the cases here.

Which rest of cases?

@ibc
Copy link
Member

ibc commented Oct 26, 2023

Why a PR draft yet? IMHO this is ready.

Ah no, a test is failing... but this cannot be related to this PR...

https://github.com/versatica/mediasoup/actions/runs/6654790668/job/18083561359?pr=1195

Ok, indeed this PR is modifying the failing test.

@nazar-pc
Copy link
Collaborator

@ibc too many notifications, GitHub is not an instant messenger, try to combine multiple messages into one and multiple comments into reviews if possible 🙏

@jmillan jmillan requested a review from ibc October 26, 2023 14:06
@jmillan
Copy link
Member Author

jmillan commented Oct 26, 2023

Bonus track from flatbuffers. All public methods are typed now.

@jmillan jmillan marked this pull request as ready for review October 26, 2023 14:26
@jmillan jmillan merged commit 7703488 into flatbuffers Oct 26, 2023
32 checks passed
@jmillan jmillan deleted the fbs-node-dump-types branch October 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmillan @ibc @nazar-pc